Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(🎁) update mypy to 0.982 #406

Closed
wants to merge 1 commit into from

Conversation

KotlinIsland
Copy link

@KotlinIsland KotlinIsland commented Nov 2, 2022

Problems:

  • Scalar seems to be getting screwed up somehow when pd.to_numeric is called
  • Series.count has an invalid overload due to None being Hashable.
    • Perhaps we could just put a type ignore on this, the real type would be something along the lines of Hashable & Not[None], which is currently not supported.

@KotlinIsland KotlinIsland mentioned this pull request Nov 2, 2022
2 tasks
@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Nov 2, 2022

@KotlinIsland please see #336 and python/mypy#13781 (comment)

We have to wait for mypy 0.990

@Dr-Irv Dr-Irv closed this Nov 2, 2022
@KotlinIsland KotlinIsland deleted the bump_mypy branch November 10, 2022 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants