-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: series.pop accepts more types than it's type signature says #627
Comments
Similar to #596, shall I create a PR to add Hashable to its signature and provide the tests? |
Yes. Thanks! |
@Dr-Irv if possible, could you make a new release on pypi with this change? |
The plan is to put in the changes described in #624 and then do a 2.0.0.yymmdd release. That will depend on getting the 2.0 changes into the stubs. I may need to alter that plan, since recent PR's have fixed things for 1.5.3. |
@anilbey just released 2.0.0.230412 . Doesn't support all the new features of 2.0, but has the fix you provided. |
Brilliant, thanks @Dr-Irv |
Describe the bug
Similar to #592, Series.pop also works on Hashable types but the signature does not mention them:
To Reproduce
Here is the code. Running it works fine.
Calling it with mypy gives the following error.
Please complete the following information:
pandas-stubs
: pandas-stubs 1.5.3.230321The text was updated successfully, but these errors were encountered: