Skip to content

Commit

Permalink
Revert "Fix CI from PR 930"
Browse files Browse the repository at this point in the history
This reverts commit 6ecbab9.
  • Loading branch information
hamdanal committed May 29, 2024
1 parent 8cf92b9 commit 399dbb7
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 17 deletions.
2 changes: 1 addition & 1 deletion pandas-stubs/core/groupby/generic.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ class DataFrameGroupBy(GroupBy[DataFrame], Generic[ByT]):
) -> DataFrame: ...
# error: overload 1 overlaps overload 2 because of different return types
@overload
def aggregate(self, func: Literal["size"]) -> Series: ... # type: ignore[overload-overlap]
def aggregate(self, func: Literal["size"]) -> Series: ... # type: ignore[overload-overlap] # pyright: ignore[reportOverlappingOverload]
@overload
def aggregate(
self,
Expand Down
31 changes: 15 additions & 16 deletions tests/test_plotting.py
Original file line number Diff line number Diff line change
Expand Up @@ -486,23 +486,22 @@ def test_plot_scatter(close_figures) -> None:
),
Axes,
)
with pytest.warns(UserWarning):
check(
assert_type(
IRIS_DF.plot.scatter(x="SepalLength", y="SepalWidth", subplots=True),
npt.NDArray[np.object_],
),
np.ndarray,
)
check(
assert_type(
IRIS_DF.plot(
x="SepalLength", y="SepalWidth", subplots=True, kind="scatter"
),
npt.NDArray[np.object_],
check(
assert_type(
IRIS_DF.plot.scatter(x="SepalLength", y="SepalWidth", subplots=True),
npt.NDArray[np.object_],
),
np.ndarray,
)
check(
assert_type(
IRIS_DF.plot(
x="SepalLength", y="SepalWidth", subplots=True, kind="scatter"
),
np.ndarray,
)
npt.NDArray[np.object_],
),
np.ndarray,
)


def test_plot_keywords(close_figures):
Expand Down

0 comments on commit 399dbb7

Please sign in to comment.