-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes and improvements #5
base: master
Are you sure you want to change the base?
Conversation
setup.py dependency handling is broken on Ubuntu - argparse is built-in on py2.7, setup.py tries to install over it. - boto also available via apt, setup.py tries to install over it too. So created requirements.txt with boto>=2.0 instead.
Fix error-handling in cmd_send by catching BotoServer error instead of checking message. Improved logging in cmd_send by printing key=value pairs containing information about SES parameters, error code, request ID and message ID. Emitted log message of "timestamp key=value ..." format can be parsed natively by Splunk.
I like everything here except for the change in the setup.py, can you explain why this change is needed? The package requires boto 2.0 and therefore belongs in install-requires of setup.py. |
Ok, we can leave out setup.py revision then, I'll try figure out why it's not detecting the existing deps. I don't see a button to exclude it though, either I'll have to rebase again to leave it out and redo the pull request, or (simpler) add a reverting commit. |
Now it will only require argparse if the Python version is known to lack a built-in argparse, is that ok? |
I found the new boto API has changed, and response struct has fields different than the code; current response has a format like,
due to this the postman send command will not respond correctly. |
about SES parameters, error code, request ID and message ID. Emitted log message of "timestamp key=value ..." format can be parsed natively by Splunk.