Enforce Pigeon minimum version in Paloma #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 14, 2023 09:09
There's no reason I can think of why this command should exist. It allows short circuiting pigeon and keeping a validator alive when they should not be.
These don't belong here. Pigeons should be sending their keepalives separately from these other processes
taariq
reviewed
Jul 14, 2023
|
I'm marking this as ready for review. After discussion in Discord, it sounds like we're aligned and agree on this strategy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Github tickets
Background
This has been a long time coming. We often release code that is incompatible with previous versions of Pigeon. Even when done in a backwards-compatible way, backwards compatibility isn't meant to extend backwards forever. We need a way of specifying the minimum version of Pigeon that the current version of Paloma works with. It's currently expected that any newer versions of Pigeon will also work with the current version of Paloma
The minimum required version of Pigeon is specified in the app.go file and should be mentioned in any proposed paloma update that goes through governance. Users can upgrade to the latest version of Pigeon ahead of the Paloma upgrade.
Part of this PR includes cleaning up extra places where we were calling the keepalive functionality. Keepalive should only happen in its own workflow, not as a tag-along to other workflows.
I also removed the ability to send a keepalive message with the CLI. I can come up with no reason why we would want to have this ability.
More info can be seen in the Epic: https://www.notion.so/volumefi/Epic-07-14-23-Governance-for-pigeon-version-check-8f8fd1dbd4d24a40a3007294f172c738
Testing completed
Breaking changes