Add error data to messages in turnstone queue #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to change Pigeon behavior. Currently, when a Pigeon encounters an error relaying a message, the pigeon just attests the message and then won't touch it again. This means for a bad message, the majority of pigeons must try to relay it in order to achieve enough attestations. With this new functionality, when an Pigeon encounters an error, it can send that error data back to Paloma. That way, all other pigeons can attest to the error without having to attempt to relay it themselves.
taariq
approved these changes
Jun 13, 2023
That is correct |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Github tickets
Background
This is needed to change Pigeon behavior. Currently, when a Pigeon encounters an error relaying a message, the pigeon just attests the message and then won't touch it again. This means for a bad message, the majority of pigeons must try to relay it in order to achieve enough attestations.
With this new functionality, when an Pigeon encounters an error, it can send that error data back to Paloma. That way, all other pigeons can attest to the error without having to attempt to relay it themselves.
Testing completed
Breaking changes