Just-in-time valset updates #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
June 8, 2023 13:16
* We need to know which snapshots are currently active for which chains. After a valset update is relayed, we are now setting that information in the snapshot
* Tests for functionality that was added * A bit of refactoring to support the tests
taariq
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes VolumeFi#273
Background
We don't want to send valset updates every 50 blocks for chains that are relatively inactive. This is a waste of money and resources. Instead, we are switching to just-in-time valset updates.
Snapshots are still taken every 50 block if worth, they just aren't pushed to target chains on every snapshot. Instead, valsets are now published to a chain in one of two cases:
Testing completed
Breaking changes