Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add breaking change section to the PR template #371

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

Vizualni
Copy link
Contributor

Background

There have been a few instances where I have thought or forgotten about code not being backwards compatible, which basically caused the testnet to halt. This is not super important for the testnet, but it's important for the mainnet, thus creating a reminder.

Testing completed

  • irrelevant

Copy link
Contributor

@measure-fi measure-fi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would probably prefer a way of testing for breaking changes, but I guess this will do for now.

@Vizualni Vizualni merged commit 15d2611 into master Aug 3, 2022
@Vizualni Vizualni deleted the mm/pr-template-breaking-changes branch August 3, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants