Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: append v2 to module name #1307

Merged
merged 1 commit into from
Oct 1, 2024
Merged

fix: append v2 to module name #1307

merged 1 commit into from
Oct 1, 2024

Conversation

maharifu
Copy link
Contributor

@maharifu maharifu commented Oct 1, 2024

Related Github tickets

Background

From v2 onwards, go forces us to either:

  • create a new directory for every version and maintain all versions within the codebase
  • append the version to the module name

We opted for the latter since we don't want to support multiple paloma versions.

Testing completed

  • test coverage exists or has been added/updated
  • tested in a private testnet

Breaking changes

  • I have checked my code for breaking changes
  • If there are breaking changes, there is a supporting migration.

@maharifu maharifu requested a review from taariq October 1, 2024 16:04
taariq
taariq approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@taariq taariq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG!

@maharifu maharifu merged commit eea138b into palomachain:master Oct 1, 2024
4 checks passed
@maharifu maharifu deleted the fix/v2_go_module branch October 1, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taariq taariq taariq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maharifu @taariq