feat: skyway nonces #1251
Merged
feat: skyway nonces #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byte-bandit
approved these changes
Aug 9, 2024
maharifu
force-pushed
the
feat/1848-skyway-nonces
branch
from
bede736 to
82df13a
Compare
maharifu
added a commit
that referenced
this pull request
Aug 16, 2024
# Related Github tickets - VolumeFi#1848 # Background Reset skyway nonce everytime we redeploy compass. - When a new compass becomes active on a chain, emit an internal event - The skyway keeper receives this event and resets the last observed nonce - Skyway attestations from the previous compass are ignored This PR will be followed by a related PR to pigeon # Testing completed - [ ] test coverage exists or has been added/updated - [x] tested in a private testnet # Breaking changes - [x] I have checked my code for breaking changes - [x] If there are breaking changes, there is a supporting migration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Github tickets
Background
Reset skyway nonce everytime we redeploy compass.
This PR will be followed by a related PR to pigeon
Testing completed
Breaking changes