Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: jit valset updates in SLCs #1247

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

maharifu
Copy link
Contributor

@maharifu maharifu commented Aug 7, 2024

Related Github tickets

Background

Before issuing a jit valset update, check the queue for existing valset updates with the same ID.

Testing completed

  • test coverage exists or has been added/updated
  • tested in a private testnet

Breaking changes

  • I have checked my code for breaking changes
  • If there are breaking changes, there is a supporting migration.

@maharifu maharifu requested a review from byte-bandit August 7, 2024 13:29
Copy link
Contributor

@byte-bandit byte-bandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we merge directly do dev16?

@maharifu maharifu force-pushed the fix/1042-jit-valset-updates branch from 872b31e to e0681fa Compare August 7, 2024 14:18
@maharifu maharifu changed the base branch from master to dev16 August 7, 2024 14:18
@maharifu maharifu requested a review from byte-bandit August 7, 2024 14:18
Before issuing a jit valset update, check the queue for existing valset
updates with the same ID.
@maharifu maharifu force-pushed the fix/1042-jit-valset-updates branch from e0681fa to ebd21c5 Compare August 7, 2024 14:22
@maharifu maharifu merged commit eeb25aa into palomachain:dev16 Aug 7, 2024
4 checks passed
@maharifu maharifu deleted the fix/1042-jit-valset-updates branch August 7, 2024 14:54
maharifu added a commit that referenced this pull request Aug 16, 2024
# Related Github tickets

- Closes VolumeFi#1042

# Background

Before issuing a jit valset update, check the queue for existing valset
updates with the same ID.

# Testing completed

- [x] test coverage exists or has been added/updated
- [x] tested in a private testnet

# Breaking changes

- [x] I have checked my code for breaking changes
- [x] If there are breaking changes, there is a supporting migration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] SLC calls spamming JIT valset updates
2 participants