feat: add fee manager to consensus #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maharifu
pushed a commit
to VolumeFi/paloma
that referenced
this pull request
Aug 16, 2024
# Background The fee manager smart contract will be independent from compass and the bridge. It will need to be deployed manually before compass, and ownership will have to be passed to compass after its deployment. > [!CAUTION] > There is no support yet for automatic compass upgrades, as they will require a handover of the fee manager just like ERC20 tokens. This will be added in a follow up MR. # Testing completed - [x] test coverage exists or has been added/updated - [ ] tested in a private testnet # Breaking changes - [x] I have checked my code for breaking changes - [x] If there are breaking changes, there is a supporting migration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The fee manager smart contract will be independent from compass and the bridge. It will need to be deployed manually before compass, and ownership will have to be passed to compass after its deployment.
Caution
There is no support yet for automatic compass upgrades, as they will require a handover of the fee manager just like ERC20 tokens. This will be added in a follow up MR.
Testing completed
Breaking changes