feat: add gas estimation logistics to Skyway #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@maharifu Since you're off today, I'm going to merge to gain some velocity. Feel free to still take a look, any findings can be addressed in a follow up. |
maharifu
pushed a commit
that referenced
this pull request
Aug 16, 2024
# Related Github tickets - VolumeFi#1761 - VolumeFi#344 # Background This change adds the needed building bricks for gas estimation to the Skyway module, which works independently from the consensus module and regular relay messages. Ideally, the Skyway stuff should be boiled down to only perform some additional logic on top of the CQ, but for now, we will have to live with this solution. # Testing completed - [x] test coverage exists or has been added/updated - [ ] tested in a private testnet # Breaking changes - [x] I have checked my code for breaking changes - [x] If there are breaking changes, there is a supporting migration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Github tickets
Background
This change adds the needed building bricks for gas estimation to the Skyway module, which works independently from the consensus module and regular relay messages. Ideally, the Skyway stuff should be boiled down to only perform some additional logic on top of the CQ, but for now, we will have to live with this solution.
Testing completed
Breaking changes