Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support event nonce ctor input for deployments #1047

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

byte-bandit
Copy link
Contributor

@byte-bandit byte-bandit commented Nov 28, 2023

Related Github tickets

Background

Adds support for setting the last observed event nonce from compass from within the constructor input during smart compass uploading. This allows updating the deployed compass contract without losing the current nonce value.

Testing completed

  • test coverage exists or has been added/updated
  • tested in a private testnet

Breaking changes

  • I have checked my code for breaking changes
  • If there are breaking changes, there is a supporting migration.

@byte-bandit byte-bandit force-pushed the feature/1002-ctor-input branch from 4fd122a to 32f5563 Compare November 28, 2023 18:02
@byte-bandit
Copy link
Contributor Author

This change does not require a new version of compass to be deployed. However, ONCE we re-deploy compass in the future, it will have to have support for this built in.

Copy link
Contributor

@taariq taariq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@taariq
Copy link
Contributor

taariq commented Nov 28, 2023

This change does not require a new version of compass to be deployed. However, ONCE we re-deploy compass in the future, it will have to have support for this built in.

@webelf101 do we need to make a PR for a new compass with this support so we can vote and redeploy compass next week?

@byte-bandit byte-bandit enabled auto-merge (squash) November 28, 2023 18:05
@byte-bandit byte-bandit merged commit d51a7db into palomachain:master Nov 28, 2023
2 checks passed
@byte-bandit byte-bandit deleted the feature/1002-ctor-input branch November 28, 2023 18:05
@byte-bandit
Copy link
Contributor Author

@taariq No need to redeploy compass next week just for the sake of supporting this change. Should be all good. Though next time we do upgrade compass for whatever reason, it will need to support this.

@taariq
Copy link
Contributor

taariq commented Nov 28, 2023

Thanks @byte-bandit, but my memory is short and I think we'll forget. Let's keep the upgrades moving. @verabehr let's open up tickets for upgrading compass to support this feature and then do the vote so we don't leave this dependent on organizational memory.

@verabehr
Copy link
Collaborator

I'm happy to open the ticket. I'm a bit confused what the actual change needed is though as @wc117 provided the correct ABI and said that no code change was needed for it. If this ABI is what is needed then what change is still pending?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants