Fix the way validator's power percentage was calculated #374

palomachain · Aug 1, 2022 · 078bac2 · 078bac2
1 parent 76430c9
commit 078bac2
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 2 deletions.
diff --git a/x/valset/keeper/keeper.go b/x/valset/keeper/keeper.go
@@ -248,8 +248,8 @@ func (k Keeper) isNewSnapshotWorthy(currentSnapshot, newSnapshot *types.Snapshot
 	// could own 60% of the network. And all other validators stayed the
 	// (relatively) same.
 	for i := 0; i < len(sortedCurrent); i++ {
-		percentageCurrent := currentSnapshot.TotalShares.ToDec().QuoInt(sortedCurrent[i].ShareCount)
-		percentageNow := newSnapshot.TotalShares.ToDec().QuoInt(sortedNew[i].ShareCount)
+		percentageCurrent := sortedCurrent[i].ShareCount.ToDec().QuoInt(currentSnapshot.TotalShares)
+		percentageNow := sortedNew[i].ShareCount.ToDec().QuoInt(newSnapshot.TotalShares)
 
 		if percentageCurrent.Sub(percentageNow).Abs().MustFloat64() >= 0.01 {
 			return true

diff --git a/x/valset/keeper/keeper_test.go b/x/valset/keeper/keeper_test.go
@@ -411,6 +411,38 @@ func TestIsNewSnapshotWorthy(t *testing.T) {
 				},
 			},
 		},
+		{
+			expRes: false,
+			name:   "if the powers are still the same then it's not worthy",
+			curr: &types.Snapshot{
+				TotalShares: sdk.NewInt(100),
+				Validators: []types.Validator{
+					{Address: sdk.ValAddress("123"), ShareCount: sdk.NewInt(20)},
+				},
+			},
+			neww: &types.Snapshot{
+				TotalShares: sdk.NewInt(100),
+				Validators: []types.Validator{
+					{Address: sdk.ValAddress("123"), ShareCount: sdk.NewInt(20)},
+				},
+			},
+		},
+		{
+			expRes: false,
+			name:   "if the powers have change for less than 1%, then it's not worthy",
+			curr: &types.Snapshot{
+				TotalShares: sdk.NewInt(1000),
+				Validators: []types.Validator{
+					{Address: sdk.ValAddress("123"), ShareCount: sdk.NewInt(20)},
+				},
+			},
+			neww: &types.Snapshot{
+				TotalShares: sdk.NewInt(1000),
+				Validators: []types.Validator{
+					{Address: sdk.ValAddress("123"), ShareCount: sdk.NewInt(21)},
+				},
+			},
+		},
 	}
 
 	for _, tt := range testcases {