-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: dbt Version detection & fix deprecation warnings in >= v1.5 #89
Merged
jakeberesford-palmetto
merged 7 commits into
palmetto:develop
from
jakeberesford-palmetto:feature/fix-deprecation-warnings
Nov 20, 2023
Merged
Feature: dbt Version detection & fix deprecation warnings in >= v1.5 #89
jakeberesford-palmetto
merged 7 commits into
palmetto:develop
from
jakeberesford-palmetto:feature/fix-deprecation-warnings
Nov 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbt version will be stored in .palm/config.yml This is a required configuration and will need to be updated by maintainers of the host project. Running `palm plugin configure --name dbt` will do automatic detection.
Projects running >= 1.5 will not see deprecation warnings
Changes depend on a refactor to run_in_docker that will be part of the next minor palm release.
jakeberesford-palmetto
requested review from
mariahjrogers and
a team
as code owners
September 8, 2023 19:39
jakeberesford-palmetto
requested review from
emilypastewka,
a user and
david-jy-kim
September 8, 2023 19:39
Tests are going to fail until palm v2.6 is released. |
jakeberesford-palmetto
changed the title
Feature/fix deprecation warnings
Feature: dbt Version detection & fix deprecation warnings in >= v1.5
Sep 12, 2023
…ig for existing users.
mariahjrogers
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Before submitting your PR, please review the following checklist:
Breaking changes
The change is semi-breaking, since it will require updating the plugin config...
What does this implement/fix? Explain your changes.
palm plugin configure --name dbt
semver
as a new dependencyDoes this close any currently open issues?
Resolves #88
Any other comments?
I don't love some of this... but it works.
Where has this been tested?
Minimally tested in local dbt project.
MacOS.
No merge so I can take more time to test this.