Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: dbt Version detection & fix deprecation warnings in >= v1.5 #89

Conversation

jakeberesford-palmetto
Copy link
Collaborator

Pull request checklist

Before submitting your PR, please review the following checklist:

  • Consider adding a unit test if your PR resolves an issue.
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Breaking changes

  • Check if this pull request introduces a breaking change

The change is semi-breaking, since it will require updating the plugin config...

What does this implement/fix? Explain your changes.

  • Adds dbt version to the plugin config.
  • Implements automatic version detection when the plugin config is initialized or re-configured with palm plugin configure --name dbt
  • Adds semver as a new dependency
  • Adds utility functions to check whether the current version is greater or less than another version.

Does this close any currently open issues?

Resolves #88

Any other comments?

I don't love some of this... but it works.

Where has this been tested?

Minimally tested in local dbt project.
MacOS.
No merge so I can take more time to test this.

dbt version will be stored in .palm/config.yml
This is a required configuration and will need to be updated by maintainers of the host project.

Running `palm plugin configure --name dbt` will do automatic detection.
Projects running >= 1.5 will not see deprecation warnings
Changes depend on a refactor to run_in_docker that will be part of the next minor palm release.
@jakeberesford-palmetto
Copy link
Collaborator Author

Tests are going to fail until palm v2.6 is released.

@jakeberesford-palmetto jakeberesford-palmetto changed the title Feature/fix deprecation warnings Feature: dbt Version detection & fix deprecation warnings in >= v1.5 Sep 12, 2023
Copy link
Collaborator

@mariahjrogers mariahjrogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

palm/plugins/dbt/commands/cmd_test.py Outdated Show resolved Hide resolved
palm/plugins/dbt/dbt_version_detection.py Show resolved Hide resolved
@jakeberesford-palmetto jakeberesford-palmetto merged commit 798f7c5 into palmetto:develop Nov 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 dbt v1.5 deprecated/renamed dbt_state_artifact_path and dbt_defer_to_state env vars
2 participants