Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Compatibility with pyyaml 6.0 #74

Conversation

jakeberesford-palmetto
Copy link
Collaborator

Pull request checklist

Before submitting your PR, please review the following checklist:

  • Consider adding a unit test if your PR resolves an issue.
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Breaking changes

  • Check if this pull request introduces a breaking change

What does this implement/fix? Explain your changes.

dbt-core now depends on pyyaml 6.0, we want to make sure folks can install palm-dbt in an environment where they are running dbt on the metal. The good news is we just have to remove the version pin. All our yaml.load calls specify the loader

Does this close any currently open issues?

Any other comments?

This change will need to be deployed along with a corresponding patch in palm cli (palmetto/palm-cli#96)

- Remove upper version pin
Copy link
Collaborator

@mariahjrogers mariahjrogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this hit everyone this week huh 😅

@jakeberesford-palmetto
Copy link
Collaborator Author

this hit everyone this week huh 😅

Thankfully we're using Loader everywhere we use yaml.load so the changeset was small.

@jakeberesford-palmetto jakeberesford-palmetto merged commit 2fa7000 into palmetto:develop Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants