[BUGFIX] Remove stateful selectors from palm run #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, as dbt run does. - Only add stateful selection on deferred runs - Fix whitespace around `full-refresh logic and make the condition a one-liner
palm/plugins/dbt/commands/cmd_run.py
Outdated
| @@ -128,6 +123,7 @@ def build_run_command( | |||
| if not no_fail_fast: | |||
| cmd.append("--fail-fast") | |||
| if defer: | |||
| cmd.extend(["--select", "state:new", "state:modified+"]) | |||
There was a problem hiding this comment.
This shouldn't be included every time the defer flag is used. Defer can be used with any model selections.
I think possibly the right condition would be if not targets and defer: for when to pass in state:new/modified. When no targets and not running with defer, default to no selection (aka run the full project or the default dbt selector).
There was a problem hiding this comment.
Yeah, this makes sense. I'll make this change.
We want to support deferred runs with selectors.
mariahjrogers
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Before submitting your PR, please review the following checklist:
Breaking changes
What does this implement/fix? Explain your changes.
palm runwas applying stateful selectors, while dbt was not using a stateful run. This makes it difficult to run the entire project and introduces an unexpected state where no models are executed.Any other comments?
Also fixed up some whitespace in the command (--fail-fast changes)
Where has this been tested?
Operating System: MacOS
Platform: Python3.9