Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Appended --full-refresh flag twice #72

Conversation

mariahjrogers
Copy link
Collaborator

@mariahjrogers mariahjrogers commented Feb 28, 2023

Pull request checklist

Before submitting your PR, please review the following checklist:

  • Consider adding a unit test if your PR resolves an issue.
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Breaking changes

  • Check if this pull request introduces a breaking change

What does this implement/fix? Explain your changes.

The build_run_command had been updated to add --full-refresh to both dbt run and dbt seed commands when the flag was used, but there was already a condition to add on the flag to the dbt run command, resulting in it being appended on twice. Functionally, it still worked, but it was a goofy mistake that doesn't need to be there!

Does this close any currently open issues?

N/A

Any other comments?

Nope

Where has this been tested?

Operating System: Mac M1 Max, Ventura OS

Platform:

Target Platform:

Copy link
Collaborator

@jakeberesford-palmetto jakeberesford-palmetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch - thanks!

@jakeberesford-palmetto jakeberesford-palmetto merged commit 1e896f9 into palmetto:develop Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants