Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix how int filter handles scientific notation #1984

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

flpm
Copy link
Contributor

@flpm flpm commented May 20, 2024

What was done:

  • handle the case where a string passed to the int filter would cause an OverflowError when float() is called. E.g. '1e100000.
  • add a new test case to test_int()
  • add entry in CHANGES.rst

fixes #1921

@flpm flpm marked this pull request as draft May 20, 2024 15:18
@davidism
Copy link
Member

git rebase --onto origin/3.1.x origin/main then git push -f

@flpm flpm force-pushed the issue-1291-int-throws-overflowerror branch from 1d98726 to cc97ac3 Compare May 20, 2024 15:32
@flpm flpm marked this pull request as ready for review May 20, 2024 15:33
@CheeseCake87 CheeseCake87 added this to the 3.2.0 milestone Dec 2, 2024
@davidism davidism changed the title [Fix] The int filter throws OverflowError for scientific notation fix how int filter handles scientific notation Dec 18, 2024
@davidism davidism modified the milestones: 3.2.0, 3.1.5 Dec 18, 2024
@davidism davidism force-pushed the issue-1291-int-throws-overflowerror branch from cc97ac3 to 2eb4542 Compare December 19, 2024 15:58
@davidism davidism merged commit 3ef3ba8 into pallets:stable Dec 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants