Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make unique filter async aware #1782

Merged
merged 1 commit into from
Dec 19, 2024
Merged

make unique filter async aware #1782

merged 1 commit into from
Dec 19, 2024

Conversation

sileht
Copy link
Contributor

@sileht sileht commented Dec 23, 2022

unique() filter doesn't work chained after a filter that return an async generator.

This introduces a async variant of the filter transform the async
generator into a list to be able to apply the unique filter.

Fixes #1781

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@sileht
Copy link
Contributor Author

sileht commented Dec 23, 2022

The pre-commit issue is not related to my change.

@sileht

This comment was marked as off-topic.

@sileht

This comment was marked as off-topic.

@davidism

This comment was marked as off-topic.

@davidism davidism added this to the 3.1.5 milestone Dec 18, 2024
@davidism davidism changed the base branch from main to stable December 19, 2024 15:25
@davidism davidism changed the title fix(filter): unique with async generator make unique filter async aware Dec 19, 2024
@davidism davidism merged commit 20be10e into pallets:stable Dec 19, 2024
12 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unique filter does not work when chain with a filter that returns async generator
3 participants