make compile_templates deterministic #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase to 3.0.x instead of main. |
davidism
reviewed
May 26, 2021
davidism
reviewed
May 26, 2021
atetubou
force-pushed
the
deterministic_test
branch
2 times, most recently
from
d0c0299 to
014f63a
Compare
atetubou
force-pushed
the
deterministic_test
branch
2 times, most recently
from
d0f0fc8 to
7598b9b
Compare
|
Thank you for review, I think I addressed your comments. |
atetubou
force-pushed
the
deterministic_test
branch
from
7598b9b to
5051f9b
Compare
|
Can I have a review again? |
|
Please don't bump posts like that. As volunteers, we will get to your pr when we have time available. |
davidism
force-pushed
the
deterministic_test
branch
from
5051f9b to
0d417f5
Compare
Python3 doesn't keep insertion order for set(), so this sorts some places for deterministic output for compiled template.
davidism
force-pushed
the
deterministic_test
branch
from
0d417f5 to
4c703ec
Compare
|
Sorry for pinging and thank you for your merge! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python3 doesn't keep insertion order for set(), so this sorts some
places for deterministic output for compiled template.
compile_templatesis non-deterministic on{% import ... as ... with context %}#1452Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.