Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config.from_json should currently be deprecated, not removed #4078

Closed
slokhorst opened this issue May 20, 2021 · 0 comments
Closed

Config.from_json should currently be deprecated, not removed #4078

slokhorst opened this issue May 20, 2021 · 0 comments
Assignees
@davidism
Milestone
2.0.1

Comments

@slokhorst
Copy link

slokhorst commented May 20, 2021 •
edited by davidism
Loading

After upgrading to Flask 2.0, using app.config.from_json() gives the following error:

AttributeError: 'Config' object has no attribute 'from_json'

The changelog only says that it has been deprecated, but not removed:

Add Config.from_file() to load config using arbitrary file loaders, such as toml.load or json.load. Config.from_json() is deprecated in favor of this. #3398
@davidism davidism added this to the 2.0.1 milestone May 20, 2021
@davidism davidism changed the title Config.from_json removal not documented Config.from_json should currently be deprecated, not removed May 20, 2021
Yourun-proger added a commit to Yourun-proger/flask that referenced this issue May 20, 2021
@Yourun-proger
updated text of changes due to pallets#4078
7eb434c
@davidism davidism self-assigned this May 20, 2021
@davidism davidism mentioned this issue May 20, 2021
Merged
6 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@davidism davidism

Labels
None yet
Projects
None yet
Milestone
2.0.1
Development

No branches or pull requests
2 participants
@davidism @slokhorst