Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/stable'
Browse files Browse the repository at this point in the history
  • Loading branch information
davidism committed Nov 13, 2024
2 parents 2eab96a + 6c44dd4 commit 22c48a7
Show file tree
Hide file tree
Showing 9 changed files with 23 additions and 6 deletions.
10 changes: 10 additions & 0 deletions docs/tutorial/database.rst
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ response is sent.
:caption: ``flaskr/db.py``
import sqlite3
from datetime import datetime
import click
from flask import current_app, g
Expand Down Expand Up @@ -132,6 +133,11 @@ Add the Python functions that will run these SQL commands to the
init_db()
click.echo('Initialized the database.')
sqlite3.register_converter(
"timestamp", lambda v: datetime.fromisoformat(v.decode())
)
:meth:`open_resource() <Flask.open_resource>` opens a file relative to
the ``flaskr`` package, which is useful since you won't necessarily know
where that location is when deploying the application later. ``get_db``
Expand All @@ -142,6 +148,10 @@ read from the file.
that calls the ``init_db`` function and shows a success message to the
user. You can read :doc:`/cli` to learn more about writing commands.

The call to :func:`sqlite3.register_converter` tells Python how to
interpret timestamp values in the database. We convert the value to a
:class:`datetime.datetime`.


Register with the Application
-----------------------------
Expand Down
4 changes: 2 additions & 2 deletions examples/celery/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ name = "flask-example-celery"
version = "1.0.0"
description = "Example Flask application with Celery background tasks."
readme = "README.md"
requires-python = ">=3.8"
dependencies = ["flask>=2.2.2", "celery[redis]>=5.2.7"]
classifiers = ["Private :: Do Not Upload"]
dependencies = ["flask", "celery[redis]"]

[build-system]
requires = ["flit_core<4"]
Expand Down
File renamed without changes.
3 changes: 2 additions & 1 deletion examples/javascript/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@ name = "js_example"
version = "1.1.0"
description = "Demonstrates making AJAX requests to Flask."
readme = "README.rst"
license = {file = "LICENSE.rst"}
license = {file = "LICENSE.txt"}
maintainers = [{name = "Pallets", email = "[email protected]"}]
classifiers = ["Private :: Do Not Upload"]
dependencies = ["flask"]

[project.urls]
Expand Down
2 changes: 1 addition & 1 deletion examples/javascript/tests/test_js_example.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
@pytest.mark.parametrize(
("path", "template_name"),
(
("/", "xhr.html"),
("/", "fetch.html"),
("/plain", "xhr.html"),
("/fetch", "fetch.html"),
("/jquery", "jquery.html"),
Expand Down
File renamed without changes.
4 changes: 4 additions & 0 deletions examples/tutorial/flaskr/db.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import sqlite3
from datetime import datetime

import click
from flask import current_app
Expand Down Expand Up @@ -44,6 +45,9 @@ def init_db_command():
click.echo("Initialized the database.")


sqlite3.register_converter("timestamp", lambda v: datetime.fromisoformat(v.decode()))


def init_app(app):
"""Register database functions with the Flask app. This is called by
the application factory.
Expand Down
3 changes: 2 additions & 1 deletion examples/tutorial/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@ name = "flaskr"
version = "1.0.0"
description = "The basic blog app built in the Flask tutorial."
readme = "README.rst"
license = {text = "BSD-3-Clause"}
license = {file = "LICENSE.txt"}
maintainers = [{name = "Pallets", email = "[email protected]"}]
classifiers = ["Private :: Do Not Upload"]
dependencies = [
"flask",
]
Expand Down
3 changes: 2 additions & 1 deletion src/flask/helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -547,7 +547,8 @@ def download_file(name):
raises a 404 :exc:`~werkzeug.exceptions.NotFound` error.
:param directory: The directory that ``path`` must be located under,
relative to the current application's root path.
relative to the current application's root path. This *must not*
be a value provided by the client, otherwise it becomes insecure.
:param path: The path to the file to send, relative to
``directory``.
:param kwargs: Arguments to pass to :func:`send_file`.
Expand Down

0 comments on commit 22c48a7

Please sign in to comment.