Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix click.confirm not working with readline module #2093

Merged
merged 1 commit into from
Oct 10, 2021
Merged

Fix click.confirm not working with readline module #2093

merged 1 commit into from
Oct 10, 2021

Conversation

alex-ball
Copy link
Contributor

Applies the patch from #665 (PR #1836) to click.confirm as well, so that the readline module does not interfere with the prompt text.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism davidism added this to the 8.0.3 milestone Oct 10, 2021
@davidism davidism changed the base branch from main to 8.0.x October 10, 2021 17:23
@davidism davidism closed this Oct 10, 2021
@davidism davidism reopened this Oct 10, 2021
@davidism davidism merged commit 3dde6c5 into pallets:8.0.x Oct 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0.3
Development

Successfully merging this pull request may close these issues.

click.confirm does not cooperate with readline
2 participants
@alex-ball @davidism