Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass extra context settings to completion #1679

Merged
merged 1 commit into from
Oct 3, 2020
Merged

Conversation

davidism
Copy link
Member

@davidism davidism commented Oct 3, 2020

The completion system created a context that ignored any extra context settings passed in like cli(obj={...}, color=False). These are now passed to the completion system, so they're reflected in the context that is built for completion.

fixes #942

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism davidism added the f:completion feature: shell completion label Oct 3, 2020
@davidism davidism added this to the 8.0.0 milestone Oct 3, 2020
@davidism davidism merged commit bc3dd47 into master Oct 3, 2020
@davidism davidism deleted the completion-context branch October 3, 2020 21:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
f:completion feature: shell completion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With argument autocompletion, context is not passed properly
1 participant