shell_completion: Raise TypeError instead of Exception

pallets · Jul 23, 2020 · 5cf7e04 · 5cf7e04
1 parent ac495a3
commit 5cf7e04
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/click/shell_completion.py b/src/click/shell_completion.py
@@ -315,7 +315,7 @@ def add_completion_class(name, completion_class):
     global available_shells
 
     if not issubclass(completion_class, ShellComplete):
-        raise Exception("Completion class must extend 'ShellComplete'")
+        raise TypeError("Completion class must extend 'ShellComplete'")
 
     available_shells[name] = completion_class
 

diff --git a/tests/test_shellcomplete.py b/tests/test_shellcomplete.py
@@ -84,7 +84,7 @@ def source(self):
         def complete(self):
             return True
 
-    with pytest.raises(Exception, match="Completion class must extend 'ShellComplete'"):
+    with pytest.raises(TypeError, match="Completion class must extend 'ShellComplete'"):
         add_completion_class("myshell", MyComplete)