Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Form to FlaskForm #249

Closed
davidism opened this issue Jun 29, 2016 · 5 comments · Fixed by #250
Closed

Rename Form to FlaskForm #249

davidism opened this issue Jun 29, 2016 · 5 comments · Fixed by #250
Assignees

Comments

@davidism
Copy link
Member

A common issue users have is that they imported wtforms.Form when they meant flask_wtf.Form, or vice versa, or they imported both and one is masking the other. We should rename flask_wtf.Form to flask_wtf.FlaskForm, and treat Form as a deprecated alias that raises a warning when it is used.

This also makes it easier to subclass both types of form in one file. For example when you want to create forms for FormField and only have CSRF handling in the main form. Right now you need to import one of the forms with an alias.

@lepture
Copy link
Contributor

lepture commented Jun 30, 2016

I agree.

@davidism davidism self-assigned this Jun 30, 2016
davidism added a commit that referenced this issue Jun 30, 2016
show deprecation warning when using Form
closes #249
davidism added a commit that referenced this issue Jun 30, 2016
show deprecation warning when using Form
closes #249
davidism added a commit that referenced this issue Jun 30, 2016
show deprecation warning when using Form
closes #249
@surlyjake
Copy link

Could you release and update the version in pypi so that users using pip can follow the new documentation?

@davidism
Copy link
Member Author

You're looking at the dev docs. Use the menu in the bottom right corner to select the stable docs. I do plan on making a release "soon", but want to get a few more changes in.

@unnamedd
Copy link

Hi @davidism,

how much time is needed to update to 0.14 on PIP ? I saw that you have a commit changing to last version, but it isn't reflected yet.

@davidism
Copy link
Member Author

davidism commented Sep 29, 2016

That's the development version, there's no changes yet. I literally just released 0.13 this morning.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants