Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed clause_to_engine bug not finding the right db bind key #1211

Merged
merged 3 commits into from
Sep 10, 2023

Conversation

ivan-gerov
Copy link
Contributor

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • [ ] Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@pamelafox
Copy link
Contributor

@davidism I added the requested newlines. I also narrowed down the types and used isinstance checks to confirm the type of class containing the table. That was after digging through the SA code to determine where the "table" attribute came from. That might mean this fix won't work for other situations, but I haven't found other classes with a table attribute that seem like they'd come into play here. I also parameterized the test to confirm it works with 2.0 style.

@pamelafox pamelafox merged commit 9e19238 into pallets-eco:main Sep 10, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Bug with getting the correct bind when clause is a statement (like Insert)
3 participants