fix: get_bind signature

CHANGES.rst

@@ -24,6 +24,14 @@ Unreleased
     ``db.session.commit()`` directly instead. :issue:`216`
 
 
+Version 2.5.2
+-------------
+
+Unreleased
+
+-   Fix session ``get_bind`` signature for SQLAlchemy 1.4. :issue:`953`
+
+
 Version 2.5.1
 -------------
 

src/flask_sqlalchemy/__init__.py

@@ -172,7 +172,14 @@ def __init__(self, db, autocommit=False, autoflush=True, **options):
             **options,
         )
 
-    def get_bind(self, mapper=None, **kwargs):
+    def get_bind(
+        self,
+        mapper=None,
+        clause=None,
+        bind=None,
+        _sa_skip_events=None,
+        _sa_skip_for_implicit_returning=False,
+    ):
         """Return the engine or connection for a given model or
         table, using the ``__bind_key__`` if it is set.
         """
@@ -191,7 +198,13 @@ def get_bind(self, mapper=None, **kwargs):
                 state = get_state(self.app)
                 return state.db.get_engine(self.app, bind=bind_key)
 
-        return super().get_bind(mapper, **kwargs)
+        return super().get_bind(
+            mapper=mapper,
+            clause=clause,
+            bind=bind,
+            _sa_skip_events=_sa_skip_events,
+            _sa_skip_for_implicit_returning=_sa_skip_for_implicit_returning,
+        )
 
 
 class _SessionSignalEvents:

tests/test_sessions.py

@@ -1,6 +1,7 @@
 import random
 
 import sqlalchemy as sa
+from sqlalchemy.engine import Engine
 from sqlalchemy.orm import sessionmaker
 
 from flask_sqlalchemy import SQLAlchemy
@@ -59,3 +60,8 @@ class QazWsx(db.Model):
 
 def test_listen_to_session_event(db):
     sa.event.listen(db.session, "after_commit", lambda session: None)
+
+
+def test_session_get_bind(app, db):
+    with app.test_request_context():
+        assert isinstance(db.session.get_bind(), Engine)