Fix subject encoding error with Python3.4 #88 #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
(looking at this as part of the PyCon US 2024 sprints) @stephane-klein @harobed We recently moved this to pallets-eco and I've been looking at merging old fixes / issues. As far as I can tell this looks approximately correct, however, your work needs to be reapplied against main. Are you interested in updating this PR or creating a new one? If so please do so and tag me. |
wlach
reviewed
May 21, 2024
| @@ -428,7 +428,12 @@ def test_unicode_subject(self): | |||
| msg = Message(subject=make_lazy_string(lambda a: a, u"sübject"), | |||
| sender='[email protected]', | |||
| recipients=["[email protected]"]) | |||
| self.assertIn('=?utf-8?q?s=C3=BCbject?=', msg.as_string()) | |||
| self.assertIn(b'=?utf-8?q?s=C3=BCbject?=', msg.as_bytes()) | |||
There was a problem hiding this comment.
Shouldn't we still test the as_string() case? I could be missing something.
|
If |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix subject encoding error with Python3.4 #88