Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code #172

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Conversation

Secrus
Copy link
Member

@Secrus Secrus commented Sep 3, 2024

Remove previously deprecated code

@davidism
Copy link
Member

davidism commented Sep 3, 2024

Since this will be the next version, go ahead and add a section to the change log and set the new version in pyproject.toml.

@Secrus Secrus requested a review from davidism September 4, 2024 08:07
@Secrus Secrus force-pushed the remove-deprecations branch from 14c086b to 55bef8f Compare September 22, 2024 16:20
@Secrus
Copy link
Member Author

Secrus commented Sep 22, 2024

@davidism done. Sorry it took so long.

@Secrus Secrus requested review from davidism and removed request for davidism September 27, 2024 15:58
@davidism
Copy link
Member

davidism commented Oct 1, 2024

I removed "(UNRELEASED)" from the changelog header and changed "Released TBD" to "Unreleased" below that, to match the style we use elsewhere. Keeping the header consistent also keeps the link to that section consistent before and after release. Other than that nitpick, looks good.

@davidism davidism merged commit 8c983ec into pallets-eco:main Oct 1, 2024
8 checks passed
@Secrus Secrus deleted the remove-deprecations branch October 10, 2024 22:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
@davidism davidism added this to the 1.9.0 milestone Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants