Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved PrEP related base scripts from the default dbo schema to PrEP s… #529

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

DennisGibz
Copy link
Contributor

@DennisGibz DennisGibz commented Dec 20, 2024

…chema

Summary by Sourcery

Chores:

  • Migrate database objects related to PrEP from the dbo schema to the PrEP schema.

Copy link

sourcery-ai bot commented Dec 20, 2024

Reviewer's Guide by Sourcery

This pull request moves all PrEP-related base scripts from the default dbo schema to the PrEP schema. This change affects multiple scripts, including those related to adverse events, behavior risks, care terminations, patients, labs, pharmacies, and visits.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Moved database objects from the dbo schema to the PrEP schema.
  • Changed table names from [ODS].[dbo].[<table_name>] to [ODS].[PrEP].[<table_name>].
  • Updated queries to reflect the new schema name PrEP.
  • Ensured that all references to PrEP-related tables now use the correct schema name PrEP.
Scripts/ODS/PrEP DOCKET/Load_PrEP_AdverseEvent.sql
Scripts/ODS/PrEP DOCKET/Load_PrEP_BehaviourRisk.sql
Scripts/ODS/PrEP DOCKET/Load_PrEP_CareTermination.sql
Scripts/ODS/PrEP DOCKET/Load_PrEP_Patient.sql
Scripts/ODS/PrEP DOCKET/Load_PrEP_Lab.sql
Scripts/ODS/PrEP DOCKET/Load_PrEP_Pharmacy.sql
Scripts/ODS/PrEP DOCKET/Load_PrEP_Visits.sql

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @DennisGibz - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider including a schema migration plan that addresses deployment order, dependency updates, and rollback procedures to ensure a smooth transition in production.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@nobert-mumo nobert-mumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants