Compatibility with dplyr 1.1.0 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Silences: ``` Use of .data in tidyselect expressions was deprecated in tidyselect 1.2.0. ℹ Please use `"n"` instead of `.data$n` ```
It now fails if supplied an unknown argument
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In dplyr 1.1.0,
left_join()will become now stricter in the arguments it accepts and will throw an error when supplied an unknown argument instead of ignoring them. In this case, you were supplying aprefixargument, presumably instead ofsuffix.This PR fixes the error and also a couple of other warnings.
We plan to release dplyr on January 27. If possible, a pre-emptive fix release would be helpful to our release process. Thanks!