Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better documentation for make_*() and unnest() functions #70

Merged
merged 2 commits into from
Aug 1, 2022

Conversation

paleolimbot
Copy link
Owner

Fixes #68.

@paleolimbot
Copy link
Owner Author

@JosiahParry is this something like what you had in mind?

@codecov-commenter
Copy link

Codecov Report

Merging #70 (be45557) into master (956a675) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #70   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files          31       31           
  Lines        2809     2809           
=======================================
  Hits         2740     2740           
  Misses         69       69           
Impacted Files Coverage Δ
R/geos-make.R 100.00% <ø> (ø)
R/geos-unnest.R 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 956a675...be45557. Read the comment docs.

R/geos-unnest.R Outdated
#' @inheritParams geos_read_wkt
#' @inheritParams wkutils::wkt_unnest
#' @param keep_empty If `TRUE`, EMPTY geomtries iare left as-is rather than

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo on "are"

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paleolimbot paleolimbot merged commit 4901af2 into master Aug 1, 2022
@paleolimbot paleolimbot deleted the doc-unnest branch August 1, 2022 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reference geos_unnest() in geos_make_collection() man page
3 participants