Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor:create views above _inventory #72

Merged
merged 4 commits into from
Oct 11, 2023
Merged

refactor:create views above _inventory #72

merged 4 commits into from
Oct 11, 2023

Conversation

xtimmy86x
Copy link
Contributor

Related Issues

#59

Proposed Changes:

Create views on the device _inventory for inputs, sectors and alerts

Checklist

  • Related issues and proposed changes are filled
  • Tests are defining the correct and expected behavior
  • Code is well-documented via docstrings

@xtimmy86x xtimmy86x changed the title refactor:create views abose _inventory refactor:create views above _inventory Oct 10, 2023
@xtimmy86x xtimmy86x changed the title refactor:create views above _inventory draft: refactor:create views above _inventory Oct 10, 2023
@xtimmy86x xtimmy86x marked this pull request as ready for review October 10, 2023 15:25
@xtimmy86x xtimmy86x changed the title draft: refactor:create views above _inventory refactor:create views above _inventory Oct 10, 2023
@palazzem palazzem self-requested a review October 10, 2023 16:25
@palazzem palazzem added this to the 2.1.0 milestone Oct 10, 2023
palazzem
palazzem requested changes Oct 11, 2023
View reviewed changes
Copy link
Owner

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change! This is really important to improve the capability of AlarmDevice and expose an API that will make the rest of our integration easier to write!

Just few suggestions, and we should be set!

tests/test_devices.py Outdated Show resolved Hide resolved
tests/test_devices.py Outdated Show resolved Hide resolved
tests/test_devices.py Outdated Show resolved Hide resolved
tests/test_devices.py Outdated Show resolved Hide resolved
tests/test_devices.py Outdated Show resolved Hide resolved
tests/test_devices.py Outdated Show resolved Hide resolved
tests/test_devices.py Outdated Show resolved Hide resolved
tests/test_devices.py Outdated Show resolved Hide resolved
tests/test_devices.py Outdated Show resolved Hide resolved
tests/test_devices.py Outdated Show resolved Hide resolved
palazzem
palazzem reviewed Oct 11, 2023
View reviewed changes
tests/test_devices.py Outdated Show resolved Hide resolved
palazzem
palazzem requested changes Oct 11, 2023
View reviewed changes
tests/test_devices.py Outdated Show resolved Hide resolved
tests/test_devices.py Outdated Show resolved Hide resolved
tests/test_devices.py Outdated Show resolved Hide resolved
tests/test_devices.py Outdated Show resolved Hide resolved
custom_components/econnect_metronet/devices.py Outdated Show resolved Hide resolved
palazzem
palazzem approved these changes Oct 11, 2023
View reviewed changes
Copy link
Owner

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes! thank you very much for helping with this refactoring! The code is improving PR after PR!

@palazzem palazzem merged commit 6dd1bee into palazzem:main Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palazzem palazzem palazzem approved these changes

Assignees

@xtimmy86x xtimmy86x

Labels
topic:entity type:refactor
Projects
e-Connect Roadmap
Archived in project
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@xtimmy86x @palazzem