Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #56

Merged
merged 2 commits into from
Oct 1, 2023
Merged

Update README.md #56

merged 2 commits into from
Oct 1, 2023

Conversation

syth87
Copy link
Contributor

@syth87 syth87 commented Sep 30, 2023 •
edited by palazzem
Loading

Related Issues

Proposed Changes:

Update README.md with Homekit configuration

Testing:

n/a

Extra Notes (optional):

n/a

Checklist

  • Related issues and proposed changes are filled
  • Tests are defining the correct and expected behavior
  • Code is well-documented via docstrings

@syth87
Update README.md
1763cc1 
docs: update README with Homekit configuration
@palazzem palazzem self-requested a review September 30, 2023 10:46
@palazzem palazzem added this to the 1.1.0 milestone Sep 30, 2023
palazzem
palazzem requested changes Sep 30, 2023
View reviewed changes
Copy link
Owner

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great contribution! Just a few little changes and we're good to go!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@syth87
Update README.md
bf4caf9 
Few changes to HomeKit section.
syth87
syth87 commented Oct 1, 2023
View reviewed changes
Copy link
Contributor Author

@syth87 syth87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update few lines

@palazzem palazzem self-requested a review October 1, 2023 13:17
palazzem
palazzem approved these changes Oct 1, 2023
View reviewed changes
Copy link
Owner

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! thank you so much for your help!

@palazzem palazzem merged commit a327b90 into palazzem:main Oct 1, 2023
@palazzem palazzem mentioned this pull request Oct 1, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palazzem palazzem palazzem approved these changes

Assignees

@syth87 syth87

Labels
type:docs
Projects
e-Connect Roadmap
Archived in project
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Improve homekit instructions to use the integration directly from there
2 participants
@syth87 @palazzem