Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add an alias to the control panel and binary sensor entities #49

Merged
merged 29 commits into from
Sep 25, 2023
Merged

feat: add an alias to the control panel and binary sensor entities #49

merged 29 commits into from
Sep 25, 2023

Conversation

xtimmy86x
Copy link
Contributor

@xtimmy86x xtimmy86x commented Sep 21, 2023 •
edited by palazzem
Loading

Related Issues

Proposed Changes:

Add an option for naming the entities with an alias

Testing:

Extra Notes (optional):

Checklist

  • Related issues and proposed changes are filled
  • Tests are defining the correct and expected behavior
  • Code is well-documented via docstrings

@xtimmy86x xtimmy86x changed the title Xtimmy86x 1.1.0.dev2 feat 1.1.0.dev1 : add an alias to the control panel and binary sensor entities Sep 21, 2023
@palazzem palazzem self-requested a review September 25, 2023 10:21
palazzem
palazzem requested changes Sep 25, 2023
View reviewed changes
Copy link
Owner

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change as it enables users to have 2+ alarm systems in HA! We really need this feature to be merged! I'll try to help you the best I can.

One thing we should do also, is to add some testing for your change, so that we're sure this behavior will never break in the future!

custom_components/elmo_iess_alarm/binary_sensor.py Show resolved Hide resolved
custom_components/elmo_iess_alarm/const.py Outdated Show resolved Hide resolved
custom_components/elmo_iess_alarm/translations/it.json Outdated Show resolved Hide resolved
custom_components/elmo_iess_alarm/binary_sensor.py Outdated Show resolved Hide resolved
@palazzem palazzem added this to the 1.1.0 milestone Sep 25, 2023
@xtimmy86x xtimmy86x changed the base branch from palazzem/v1.1.0.dev1 to main September 25, 2023 13:01
@xtimmy86x xtimmy86x changed the title feat 1.1.0.dev1 : add an alias to the control panel and binary sensor entities feat: add an alias to the control panel and binary sensor entities Sep 25, 2023
palazzem
palazzem requested changes Sep 25, 2023
View reviewed changes
Copy link
Owner

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're almost there! Just few changes and let's include tests for your new function!

custom_components/elmo_iess_alarm/binary_sensor.py Outdated Show resolved Hide resolved
custom_components/elmo_iess_alarm/helpers.py Outdated Show resolved Hide resolved
custom_components/elmo_iess_alarm/helpers.py Show resolved Hide resolved
custom_components/elmo_iess_alarm/binary_sensor.py Outdated Show resolved Hide resolved
@xtimmy86x @palazzem
Update config_flow.py
fe60bfc 
Added option for naming the entities with an alias
@xtimmy86x @palazzem
Update strings.json
f7a30c7 
Add an option for naming the entities with an alias
@xtimmy86x @palazzem
Update it.json
3dadddb 
Add an option for naming the entities with an alias
@xtimmy86x @palazzem
Update en.json
49c56a8 
Add an option for naming the entities with an alias
@xtimmy86x @palazzem
Update const.py
98dc170 
Add an option for naming the entities with an alias
@xtimmy86x @palazzem
Update alarm_control_panel.py
2d5bd2e 
Add an option for naming the entities with an alias
@xtimmy86x @palazzem
Update binary_sensor.py
207871d 
Add an option for naming the entities with an alias
@xtimmy86x @palazzem
Update manifest.json
18e7a10
@xtimmy86x @palazzem
Update alarm_control_panel.py
f064552
@xtimmy86x @palazzem
Update binary_sensor.py
ced07b5
@xtimmy86x @palazzem
Update config_flow.py
4a76bd8
@xtimmy86x @palazzem
Update const.py
a5e71ec
@xtimmy86x @palazzem
Update strings.json
ac9d1d1
@xtimmy86x @palazzem
Update en.json
6e3ae04
@xtimmy86x @palazzem
Update it.json
7a5d59f
@xtimmy86x @palazzem
Update helpers.py
91470ce
@xtimmy86x @palazzem
Update helpers.py
c8ae35c
@xtimmy86x @palazzem
Update binary_sensor.py
b92b001
@palazzem palazzem self-requested a review September 25, 2023 16:19
palazzem
palazzem approved these changes Sep 25, 2023
View reviewed changes
Copy link
Owner

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great change! Thank you very much for iterating over my suggestions!

@palazzem palazzem merged commit 9117840 into palazzem:main Sep 25, 2023
@palazzem palazzem deleted the xtimmy86x-1.1.0.dev2 branch September 25, 2023 16:22
@palazzem palazzem mentioned this pull request Sep 27, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palazzem palazzem palazzem approved these changes

Assignees

@xtimmy86x xtimmy86x

Labels
breaking change topic:entity type:feature
Projects
e-Connect Roadmap
Archived in project
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@xtimmy86x @palazzem