-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(alarm): address HA 2025.x deprecations #171
fix(alarm): address HA 2025.x deprecations #171
Conversation
Thank you very much @andreapier ! I'll take a look at it today, so when it's ready I can ship a new release! Thank you very much for looking into this! |
Pull Request Test Coverage Report for Build 11775441334Details
💛 - Coveralls |
Hi, any news? |
Hello @andreapier ! I've scheduled time tomorrow morning, as I would like to fix other things after reviewing your PR and ship a new version. I'll give you feedback as soon as tomorrow morning! Thanks again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for addressing these deprecations! Your changes look good, and I only left two questions before we can merge. Regarding GitHub actions:
- Coveralls fails, but it's because you removed 2 untested lines and then you added 1 new line (ref) so we can ignore the fact it fails
- I run all other actions and they pass, I don't know why GitHub is not getting the result
Anyway, if you can just answer both questions to be 100% sure, I'll merge everything and will start the release process. Thank you again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good, thanks for taking the time to investigate these deprecations, taking the time to do the change and for answering my questions!
I'm going to ship a 2.4.1 beta before the final release just to do some testing before a stable release. Also, feel free to join our Discord channel as I'm easy to reach out there! https://discord.gg/NSmAPWw8tE
Thanks again!
Related Issues
Proposed Changes:
I recently started to look into this component and noticed that it is notifying a few deprecations, so I thought I could help fixing those
Testing:
This only relates to HA changes so no new test is needed (in my opinion)
Extra Notes (optional):
The deprecations I fixed are:
async_config_entry_first_refresh
, which is only supported when entry state is ConfigEntryState.SETUP_IN_PROGRESS, but it is in state ConfigEntryState.NOT_LOADED, This will stop working in Home Assistant 2025.11 (fixed in b709f13)One thing I was not sure about (but figured out I would try and if you don't agree I could go back and fix it) is about "Fix alarm_state deprecation for HA Core 2025.11". Before my changes the state was "unavailable" before the first state update. Now it is None (we can now only return enum values defined in
AlarmControlPanelState
, and there is no value for unedefined).Is it ok for you?
Checklist