Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(log): forcing a full update is not considered an error #130

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

palazzem
Copy link
Owner

@palazzem palazzem commented Feb 1, 2024

Related Issues

Proposed Changes:

Changes debug level from ERROR to DEBUG when a full update is required.

Testing:

n/a

Extra Notes (optional):

This partially solves the issue in #121 where, in some cases, sensors can still be detected as unavailable. For further improvements, we should rewrite the AlarmCoordinator logic as we may need to handle updates differently.

Checklist

  • Related issues and proposed changes are filled
  • Tests are defining the correct and expected behavior
  • Code is well-documented via docstrings

@palazzem palazzem added this to the 2.3.0 milestone Feb 1, 2024
@palazzem palazzem self-assigned this Feb 1, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7745015757

  • 0 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.095%

Totals Coverage Status
Change from base Build 7744197143: 0.0%
Covered Lines: 597
Relevant Lines: 629

💛 - Coveralls

@palazzem palazzem merged commit a699621 into main Feb 1, 2024
5 checks passed
@palazzem palazzem deleted the palazzem/issue-121 branch February 1, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants