Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add AWAY state configuration #107

Merged
merged 3 commits into from
Nov 8, 2023
Merged

feat: add AWAY state configuration #107

merged 3 commits into from
Nov 8, 2023

Conversation

palazzem
Copy link
Owner

@palazzem palazzem commented Nov 8, 2023 •
edited
Loading

Related Issues

Proposed Changes:

Adds arm AWAY configuration in the OptionsFlow step with the following logic:

  • After version update, the setting is empty
  • If the setting is not set (empty), the device arms all sectors (backward compatibility)
  • If the setting is set, only selected sectors are armed

Example

image

Testing:

  1. Arming the system without setting the option should arm all sectors
  2. Arming the system with the option set, should arm only selected sectors

Extra Notes (optional):

n/a

Checklist

  • Related issues and proposed changes are filled
  • Tests are defining the correct and expected behavior
  • Code is well-documented via docstrings

@palazzem palazzem added this to the 2.2.0 milestone Nov 8, 2023
@palazzem palazzem self-assigned this Nov 8, 2023
@palazzem palazzem mentioned this pull request Nov 8, 2023
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6797771020

  • 4 of 4 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 94.249%
Totals Coverage Status
Change from base Build 6797209446: 0.2%
Covered Lines: 504
Relevant Lines: 536
💛 - Coveralls

@palazzem palazzem merged commit 6c4e308 into main Nov 8, 2023
@palazzem palazzem deleted the palazzem/task-96 branch November 8, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@palazzem palazzem

Labels
topic:entity type:feature
Projects
e-Connect Roadmap
Archived in project
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

Users can configure AWAY state if needed
2 participants
@palazzem @coveralls