Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use multi select in setup options #101

Merged
merged 9 commits into from
Nov 8, 2023

Conversation

xtimmy86x
Copy link
Contributor

@xtimmy86x xtimmy86x commented Nov 1, 2023

Related Issues

Closes #60

Proposed Changes:

Transform the configuration of sectors in the options flow from textual input to a multi-select interface for a better and more user-friendly experience:

  • Add select component for the OptionsFlow
  • Include migration between options v2 -> v3 to avoid breaking changes
  • Remove parse_areas_config utility as validation is handled in the select component

Testing:

Extra Notes (optional):

Old method:

Screenshot 2023-11-01 143109

New method:

Screenshot 2023-10-28 151540

Checklist

  • Related issues and proposed changes are filled
  • Tests are defining the correct and expected behavior
  • Code is well-documented via docstrings

Sorry, something went wrong.

@coveralls
Copy link

coveralls commented Nov 1, 2023

Pull Request Test Coverage Report for Build 6755453540

  • 35 of 35 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.4%) to 94.071%

Totals Coverage Status
Change from base Build 6748151324: 2.4%
Covered Lines: 501
Relevant Lines: 534

💛 - Coveralls

Copy link
Owner

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have few suggestions and questions before we can merge this PR! In any case, great change!

@xtimmy86x xtimmy86x force-pushed the xtimmy86x/refactor-config-flow branch from 99a596a to 5435f9e Compare November 3, 2023 15:22

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@xtimmy86x xtimmy86x force-pushed the xtimmy86x/refactor-config-flow branch from 5435f9e to cb9fcd0 Compare November 3, 2023 17:49
@palazzem palazzem self-assigned this Nov 4, 2023
Copy link
Owner

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After these changes and internal QA, we can merge this great work! Thank you so much for the effort!

@palazzem palazzem merged commit becc4db into palazzem:main Nov 8, 2023
@xtimmy86x xtimmy86x deleted the xtimmy86x/refactor-config-flow branch November 8, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Integration config form: replace text inputs with entity lookup widgets
3 participants