-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use multi select in setup options #101
refactor: use multi select in setup options #101
Conversation
Pull Request Test Coverage Report for Build 6755453540
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have few suggestions and questions before we can merge this PR! In any case, great change!
99a596a
to
5435f9e
Compare
5435f9e
to
cb9fcd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After these changes and internal QA, we can merge this great work! Thank you so much for the effort!
Related Issues
Closes #60
Proposed Changes:
Transform the configuration of sectors in the options flow from textual input to a multi-select interface for a better and more user-friendly experience:
select
component for theOptionsFlow
parse_areas_config
utility as validation is handled in theselect
componentTesting:
Extra Notes (optional):
Old method:
New method:
Checklist