Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use multi select in setup options #100

Closed

Conversation

xtimmy86x
Copy link
Contributor

Related Issues

Closes #60

Proposed Changes:

Transform the configuration of sectors in the options flow from textual input to a multi-select interface for a better and more user-friendly experience

Testing:

Extra Notes (optional):

Old method:

Screenshot 2023-11-01 143109

New method:

Screenshot 2023-10-28 151540

Checklist

  • Related issues and proposed changes are filled
  • Tests are defining the correct and expected behavior
  • Code is well-documented via docstrings

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6720371468

  • 61 of 66 (92.42%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 88.031%

Changes Missing Coverage Covered Lines Changed/Added Lines %
custom_components/econnect_metronet/helpers.py 9 10 90.0%
custom_components/econnect_metronet/config_flow.py 2 6 33.33%
Files with Coverage Reduction New Missed Lines %
custom_components/econnect_metronet/config_flow.py 1 62.82%
Totals Coverage Status
Change from base Build 6677072536: -0.3%
Covered Lines: 480
Relevant Lines: 548

💛 - Coveralls

@xtimmy86x xtimmy86x closed this Nov 1, 2023
@xtimmy86x xtimmy86x deleted the xtimmy86x/refactor-config-flow branch November 1, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration config form: replace text inputs with entity lookup widgets
2 participants