Send shutdown messages to users when signaltower shuts down #24
Conversation
| _ -> | ||
| :ok | ||
| end) | ||
| end |
There was a problem hiding this comment.
... Is this the signal handler
There was a problem hiding this comment.
What do you mean by signal handler? stop(state) is a callback of the Application behaviour ("interface") and it gets called when the application is asked to shut down - is that what you mean?
There was a problem hiding this comment.
Thats what i mean. I was refering to signal handlers used in c++ programms.
There was a problem hiding this comment.
Is the 'asked to shutdown' compareable to unix signal e.g.: sigterm?
There was a problem hiding this comment.
Exactly. "By default, a SIGTERM from the operating system will automatically translate to System.stop/0." https://hexdocs.pm/elixir/Application.html
lib/signal_tower.ex
Outdated
| @@ -45,4 +40,16 @@ defmodule SignalTower do | |||
| Logger.info("SignalTower started") | |||
| ret | |||
| end | |||
|
|
|||
| @impl Application | |||
| def stop(_) do | |||
There was a problem hiding this comment.
I liked the _state in the previous version, because it gives me an idea about the variable content/type
There was a problem hiding this comment.
Ok, I will bring it back ;-)
Closes #20