Add noForIn rule #4747
Add noForIn rule #4747
Conversation
|
Thanks for your interest in palantir/tslint, @jpike88! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
|
@JoshuaKGoldberg am trying to make that test pass... could you suggest the correct code for that? |
|
Try merging master to get the fix for #4745 |
|
@JoshuaKGoldberg finally, looking forward to the pr and release! |
|
Guys, any movement? |
|
@jpike88 thanks for updating the PR, I'll take a look today |
test/rules/no-for-in/test.ts.lint
Outdated
| const object = {test:1, test2:1 ,test3:1}; | ||
| for (const key in object) { | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| if (object.hasOwnProperty(key)) {. |
There was a problem hiding this comment.
| if (object.hasOwnProperty(key)) {. | |
| if (object.hasOwnProperty(key)) { |
There was a problem hiding this comment.
| if (object.hasOwnProperty(key)) {. |
There was a problem hiding this comment.
| if (object.hasOwnProperty(key)) {. | |
| if (object.hasOwnProperty(key)) { |
test/rules/no-for-in/test.ts.lint
Outdated
| @@ -0,0 +1,23 @@ | |||
| // this should pass | |||
There was a problem hiding this comment.
no need to write this, it's implied by the lack of lint failure marker
There was a problem hiding this comment.
| // this should pass |
Co-Authored-By: Adi Dahiya <[email protected]>
|
You missed some of my code suggestions - please go to the Files tab of the PR and apply them all as a batch |
Co-Authored-By: Adi Dahiya <[email protected]>
Co-Authored-By: Adi Dahiya <[email protected]>
Co-Authored-By: Adi Dahiya <[email protected]>
|
@adidahiya at last... hopefully this is it lol |
|
thanks @jpike88! |
PR checklist
Overview of change:
Is there anything you'd like reviewers to focus on?
I have no idea what I'm doing, this is taken straight from the Microsoft-tslint-contrib repo, with some minor tweaks made. Help lol
CHANGELOG.md entry:
[new-rule]
no-for-in