[quotemark] Excuse more backtick edge cases

[ericbf]

This edge cases were previously flagged when they should be ignored, as changing them breaks typescript. This commit makes it so they are ignored. It also organizes a little better, using functions instead of multi-layered conditionals (it was getting confusing).

PR checklist

• Addresses an existing issue: [quotemark: backtick] Incorrectly flags string literals in export line #4588, fixes [quotemark] backtick breaks old typescript #4645
• New feature, bugfix, or enhancement
  • Includes tests
• Documentation update

Overview of change:

I keep finding other edge cases that I previously missed. I think this is all of them now, but we shall see. Related to #4588.

Is there anything you'd like reviewers to focus on?

See if y'all find any other edge cases.

CHANGELOG.md entry:

[bugfix] Excuse more quotemark backtick edge cases and fix behavior for TS < 2.7.1

[JoshuaKGoldberg]

A little confused about the 2.7.1 change. Some discussion (preferably in an issue) would be good.

[JoshuaKGoldberg]

Directly checking ts.version is a little unusual... maybe there's a cleaner way? Thoughts @adidahiya?

Also, @ericbf, could you elaborate on why this is necessary?

[ericbf]

Typescript below the listed version fails compilation (or otherwise misbehaves) when backticks are used in some places where it succeeds in future versions. For instance, typeof str === `string`​ does not narrow the type of str in TS versions below 2.7.1, causing compilation errors if you try to use it as a string later. In the other cases, older TS throws errors where NoSubstitutionLiterals are used instead of single/double quoted strings, but works fine in above 2.7.1; rather than cripple the rule to support order versions, I split it up.

[ericbf]

See the typeof issue here. Its milestone was 2.7 (hence the split in this PR).
And here's the issue for backticks strings as types. This one was 2.6, but rather than doing multiple splits, I just did one at 2.7.

[ericbf]

Created corresponding issue, #4645

[JoshuaKGoldberg]

Thanks! This LGTM but before merging I'd like to hear from adidahiya on whether there's a cleaner way to check on these things.

[adidahiya]

I agree it's unusual and should be avoided if possible, but this seems like a reasonable use case for checking ts.version.

However, can you please use the semver package and the helper function from parse.ts to check version ranges instead?

import { lt } from "semver";
import { getNormalizedTypescriptVersion } from "../../verify/parse";

function hasOldTscBacktickBehavior() {
    return lt(getNormalizedTypescriptVersion(), "2.7.1");
}

[ericbf]

Any update here? @adidahiya? @JoshuaKGoldberg?

[ericbf]

Any update here?

[adidahiya]

I agree it's unusual and should be avoided if possible, but this seems like a reasonable use case for checking ts.version.

However, can you please use the semver package and the helper function from parse.ts to check version ranges instead?

import { lt } from "semver";
import { getNormalizedTypescriptVersion } from "../../verify/parse";

function hasOldTscBacktickBehavior() {
    return lt(getNormalizedTypescriptVersion(), "2.7.1");
}

[adidahiya]

Also if you merge master you'll get the new required CI check, "clean-lockfile"

approved