-
Notifications
You must be signed in to change notification settings - Fork 887
Add option to ignore accessors in adjacent-overload-signatures #3718
Add option to ignore accessors in adjacent-overload-signatures #3718
Conversation
Because getters/setters are not overloads, I am thinking if this behavior should be configurable at all. Maybe the rule should be just changed to ignore getters/setters? If you agree I can remove this PR and create a new one |
@saberduck ah great point about them not being overloads. i actually like how the rule works currently, where it keeps |
1bd8bc5
to
b8f8de9
Compare
@giladgray I fixed the options schema, please have a look |
b8f8de9
to
9962297
Compare
@giladgray can you please review again? |
…in_adjacent_overload
It seems that new precommit hook reformats |
@saberduck yeah that problem's on TSLint's end; it's not a problem if your PR contains the changes. Prettier was enabled before everything was merged, so there are still a few files that need to be manually reformatted... |
Sorry for the delay @saberduck! I'm applying the formatting & merge changes now, and will merge this in once the build passes. It'll be available in the next TSLint release. Just a heads up - I'm also changing the rule's options to be of the form |
PR checklist
Overview of change:
This change adds option to ignore getters / setters when considering overloads in adjacent-overload-signatures to allow grouping getters and setters together.
CHANGELOG.md entry:
[new-rule-option]
"ignore-accessors"
foradjacent-overload-signatures
to ignore getters / setters overloads