-
Notifications
You must be signed in to change notification settings - Fork 887
no-magic-numbers rule ignores arguments in Number prototype methods #3668
no-magic-numbers rule ignores arguments in Number prototype methods #3668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me @mateuszwitkowski, thanks! Would you mind merging master into your branch so that the tests pass?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mateuszwitkowski this is sweet! few small changes please.
@mateuszwitkowski please update this branch (fix build & merge conflicts) so we can review it, or close it if no longer relevant. we will close this if we do not hear from you in two weeks. |
…agic-numbers-ignore
@giladgray I've just updated this PR so it's ready to go. |
👋 @mateuszwitkowski, just a heads up that this is merged in now and will be available in the next TSLint release. Sorry it took so long to get in! The changes look great. |
@JoshuaKGoldberg Great! Thanks for the notice :) |
PR checklist
no-magic-numbers
should ignore various Number methods' params #3653Overview of change:
no-magic-numbers rule now ignores arguments in following default Number prototype methods:
CHANGELOG.md entry:
[enhancement]: no-magic-numbers rule ignores arguments passed into default Number methods