Error-prone 2.15.0 #1562
Closed
Error-prone 2.15.0 #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlosna
added
merge when ready
no changelog
dependencies
schlosna
force-pushed
the
ds/error-prone-2.15.0
branch
from
9485af3 to
5d70bb0
Compare
carterkozak
reviewed
Sep 12, 2022
| @@ -5,9 +5,9 @@ buildscript { | |||
| } | |||
|
|
|||
| dependencies { | |||
| classpath 'com.google.errorprone:error_prone_core:2.15.0' | |||
There was a problem hiding this comment.
Thoughts on removing this in order to pick up error_prone 2.15.0 from gradle-baseline?
https://github.com/palantir/gradle-baseline/blob/4.161.0/versions.lock#L17-L23
carterkozak
reviewed
Sep 12, 2022
| @@ -84,6 +84,7 @@ allprojects { | |||
| ).collect { it.canonicalName() } as String[]) | |||
|
|
|||
| disable 'AndroidJdkLibsChecker', // ignore Android | |||
| 'CanIgnoreReturnValueSuggester', // high noise on builders | |||
There was a problem hiding this comment.
Latest baseline should take care of this out of the box: https://github.com/palantir/gradle-baseline/blob/4d9c322805ac8fbc1967baa529d5d1a609513fbe/gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineErrorProne.java#L173
There was a problem hiding this comment.
#1567 to switch over to gradle-baseline provided error-prone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Outdated error-prone. Simpler alternative to #1543
After this PR
==COMMIT_MSG==
Error-prone 2.15.0
==COMMIT_MSG==
Possible downsides?