[SPARK-26713][CORE][followup] revert the partial fix in ShuffleBlockFetcherIterator #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n task is finished" This reverts commit 1280bfd.
…ask is finished ### What changes were proposed in this pull request? Manually release stdin writer and stderr reader thread when task is finished. This is the backport of apache#23638 including apache#25049. ### Why are the changes needed? This is a bug fix. PipedRDD's IO threads may hang even the corresponding task is already finished. Without this fix, it would leak resource(memory specially). ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Add new test Closes apache#25825 from advancedxy/SPARK-26713_for_2.4. Authored-by: Xianjin YE <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
rshkv
commented
Mar 12, 2021
Comment on lines
-413
to
+406
| while (!isZombie && result == null) { | ||
| while (result == null) { |
There was a problem hiding this comment.
IIUC this thread correctly, we can get race conditions on the isZombie flag.
rshkv
commented
Mar 12, 2021
| @@ -410,7 +403,7 @@ final class ShuffleBlockFetcherIterator( | |||
| // then fetch it one more time if it's corrupt, throw FailureFetchResult if the second fetch | |||
| // is also corrupt, so the previous stage could be retried. | |||
| // For local shuffle block, throw FailureFetchResult for the first IOException. | |||
| while (!isZombie && result == null) { | |||
| while (result == null) { | |||
| val startFetchWait = System.currentTimeMillis() | |||
| result = results.take() | |||
LorenzoMartini
changed the title
LorenzoMartini
approved these changes
Mar 15, 2021
|
Thank you, @LorenzoMartini. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a clean cherry-pick of apache#25825, back-ported to our 2.x branch.
We're instances instances recently of task threads hanging while waiting for shuffle results. It seems related to SPARK-26713. It also matches the difference we have with upstream's latest 2.4.x release.
It was easier to revert the commit that introduced the first fix, and then cherry-pick the combined back-port from here: apache#25825 (as opposed to just take the correction).